Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Suggestion List #1408

Open
Tomi010817 opened this issue Oct 20, 2020 · 1 comment
Open

My Suggestion List #1408

Tomi010817 opened this issue Oct 20, 2020 · 1 comment

Comments

@Tomi010817
Copy link

Tomi010817 commented Oct 20, 2020

Introduction

So today I completely finished setting up my faction's config, and through the process of it, I found various details that can be fixed to be much more comfortable for the people that is going to use this plugin, so in this github post I'm going to share all of them. If I didn't clarify well on any of them, please notice me about it.

Suggestions:

1- An exclusive permission only for faction roles mod and coleader, on the perms menu. This new permission would consist of letting or not to people with that role, to set relations with other factions.

2- A permission for all the categories on the perms menu, that would consist of letting or not to deposit money on your faction.

3- A permission for all the categories on the perms menu, that would consist of letting or not to withdraw money on your faction.

4- An option on the main.config, so that if it is enabled, it would force all created faction tags to start with an uppercase on the first letter. Currently there is only an option to force the faction tags to be fully uppercase.

5- An exclusive permission only for faction roles mod and coleader, on the perms menu. This one would consist of letting or not to bypass ownerships set on the land of your faction. Currently, moderators and coleaders can bypass them and the only way to stop that is through the main config, and it would only stop moderators. This new permission would make it so much customizable.

6- An exclusive permission only for faction roles mod and coleader, on the perms menu. This one would consist of letting or not to toggle your faction status either to private or public. The reason is the same as the suggestion above, but on this one you can't even stop it through the config.

7- For reasons of logic, I think that the faction should become raidable only if the total power is less than the total land. Currently, the faction becomes raidable if the total power is less or equal than the total land, and this is a problem because if someone has 10 of power, decides to create a faction, and claims 10 lands, then his faction will be raidable because the total power is equal to the total land, and it doesn't make much sense.ADDED

8- Make an option on the main.config to disable self-demoting, with an included error message when trying to demote yourself.

9- An option on the config, to stop requiring a player to declare as enemy the faction where he is stood in order to combat with the players that are also inside of that land. Currently you could technically fix this by stopping FactionsUUID from handling the PvP, but this would also stop avoiding allies from fighting each other which is not a good thing.

10- On most of the messages, when you appear on them, instead of showing you your name, it replaces to "you". I know that you can change the "you" format on the lang file, but when it comes to translating all the messages, some of them look very bad structured, to the point that just showing your actual name would be much more comfortable instead. So an option on the main.config to stop replacing your name to "you" on the messages, would be very good.

11- The same as the suggestion above, but for "your faction".

12- Be able to set somewhere on the config, the minimum money required to deposit. Another one for withdrawing would also be useful. Currently you can even deposit and withdraw 0 money from a faction, and even the message gets broadcasted.

14- Also be able to set somewhere on the config, the characters limit for the description of a faction, as there is currently no limit.

15- The permission factions.promote should be also inherited by default for everyone.

16- A new permission to bypass the cooldown for going to any faction home.

17- An option on the main config to decide if you want or not the relation color variable and placeholder to
affect your name, this would mean that if you disable it, it would not affect you and would always stay white
even if you have a faction, and it would only affect others, but if you have it enabled, then it will affect your name
and turn green when you are in a faction.
This one may not look that useful, but it will make it more customizable and it would also help me a lot since I use the relation color placeholder for many places on my server, and on some of them, it just looks much better to see your name in white on all circumstances and to only affect other players names. (for example: on the players tags for the tablist)

18- The faction coleader should be able to use /f mod because when you are moderator and try to make someone also moderator, it will tell you on chat that "You must be coleader", but once you are coleader and you try again, it tells you "you must be admin". This should be allowed for the coleader unless it has the permission "promote" denied on the permissions menu of that faction.ADDED

19- The promote message is a little buggy, and when you demote someone all the way down to recruit, it will tell you that "You can't promote that player" when it should be "You can't demote that player". I guess there should be a separate message for the demoting error message, and for the promoting one so it doesn't conflict.

Those are all the suggestions that I have for this awesome plugin, thanks in advance for reading!
If you want to leave your opinion or correct me somewhere, just reply. English is not my main language and I may have some typos. Regards!


EDIT: 11-11-2020

I've already been running my server with lot of users using this amazing faction's system, and today I wanted to highlight the 4 suggestions that I would consider the most important, since they affect the playability a lot.

Ordered from most important, to less important:

1st - The raidability status, should be acquired only if the faction's power is less than the faction's total chunks claimed. Everyone in my server is just claiming territory for their faction until they reach the limit because of their power, and they do not realize that the faction becomes raidable because the total power of their factions is equal to the amount of chunks claimed.ADDED

2nd - There must be an option on the main.config to be able to allow the pvp for a player that is inside of the territory of a neutral faction. I got ton of reports from users, because they get tpkilled' and they can't defend themselves because they are factionless inside of a faction's territory, or just can't declare the faction as enemy because of the combat tag system. I do love the pvp handling system that this plugin brings, specially the antipvp between alliances or players from the same faction, so it would be sweet to have that option on the main.config.

3rd - There should be a permission on the /f perms list, to allow or not the roles or relations, to harm animals or friendly entities. People always realizes late, when they expose their animals or pets too much on their faction territory, and then get killed by a random guy that was just walking by and found their faction. Also there is a bug that should be fixed, players should not be able to smash your crops on your faction's territory, when they don't have permission to destroy inside your faction's territory, it should act equally as WorldGuard. And another bug, is that furnace is taken as a "CONTAINER" but the turned on furnace which has a different id, it isn't taken as a "CONTAINER" by this plugin, resulting in everyone being able to open the furnace on the timelapse where it is cooking something.

4th - You should add a check for the Bukkit/Spigot function that hides players and is used by most of the vanish plugins to hide player, so that if the player is vanished, then it would appear as "offline" on their faction info dashboard (/f show).


EDIT: 12-14-2020

Another bug spotted: even if you enable the explosion protection from creepers and tnt on a faction's land, item frames, paintings, and armorstands will still break when a creeper or a tnt explodes.FIXED

A dope suggestion: It would be really epic to make beacons inside of a faction's land, to give effects only to the members of that faction, and to include a permission on the /f perms menu to be able to decide to which role/relation to also give effects when that beacon belongs to the land of your faction.


EDIT: 03-10-2021

A good feature would be able to have a permission so you don't loose power when you die. Or even a mechanism on the config file or on the permission node, so that you can make some special people on your server lose less power on death than other people.

@SekiAlpha
Copy link

You should probably open up another issue for your issue with explosives. Check to see if someone else posted about it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants