Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Headers on TLS -> Non-TLS using createB2BUA #89

Open
lylepratt opened this issue Jul 20, 2020 · 1 comment
Open

Issue with Headers on TLS -> Non-TLS using createB2BUA #89

lylepratt opened this issue Jul 20, 2020 · 1 comment

Comments

@lylepratt
Copy link

Howdy Dave,

I've encountered another odd TLS issue (similar to the one reported here drachtio/drachtio-sip#3). It appears that the From header sent on the B side of a B2BUA doesn't get populated with the calling number if TLS is used on the A side.

A Side:
From: <sips:[email protected]:5061>
Contact: <sips:[email protected]:58726;transport=tcp>

  drachtio:agent INVITE sips:[email protected]:5061 SIP/2.0
  drachtio:agent Via: SIP/2.0/TLS 192.168.1.109:56254;branch=z9hG4bKwbq5Dg8R82Q3mian;rport=58726;received=172.17.0.1
  drachtio:agent Contact: <sips:[email protected]:58726;transport=tcp>
  drachtio:agent Max-Forwards: 70
  drachtio:agent From: <sips:[email protected]:5061>;tag=DEF6E8FE2F1787CFE1FBFD518AB1E03F
  drachtio:agent Allow: ACK, BYE, CANCEL, INFO, INVITE, NOTIFY, OPTIONS, REFER
  drachtio:agent Supported: replaces, path
  drachtio:agent To: <sips:[email protected]:5061>
  drachtio:agent Content-Type: application/sdp
  drachtio:agent Call-ID: 6C629A2A66EB4F68DCD2AC759DFCF27FF212D63A
  drachtio:agent CSeq: 2 INVITE
  drachtio:agent User-Agent: Vida/0.0.2
  drachtio:agent Content-Length: 695

B Side:
From: <sip:24.55.5.163:5060> <-- Missing value
Contact: <sip:24.55.5.163:5060> <-- Missing value

  drachtio:agent INVITE sip:[email protected];transport=udp SIP/2.0
  drachtio:agent Via: SIP/2.0/UDP 24.55.5.163;rport;branch=z9hG4bKgF7K5ZpaKBNcF
  drachtio:agent Max-Forwards: 70
  drachtio:agent From: <sip:24.55.5.163:5060>;tag=c7tK9Z6855g7m
  drachtio:agent To: <sip:[email protected]>;transport=udp
  drachtio:agent Call-ID: f3b8efd2-4562-1239-a484-0242ac110002
  drachtio:agent CSeq: 23083060 INVITE
  drachtio:agent Contact: <sip:24.55.5.163:5060>
  drachtio:agent Content-Type: application/sdp
  drachtio:agent Content-Length: 593

Interestingly, if I force my client to use "sip:" addresses with TLS (instead of "sips:"), then it works fine.

@byoungdale
Copy link

byoungdale commented Sep 17, 2020

I did some testing and it looks like what you brought up in drachtio/drachtio-sip#3 is correct. I made a pull request that should address the issue. Now though I'm trying to think how to setup a automated test case to add to the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants