Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StashPop fails to load on PR pages with empty "Non-default test suites" options #77

Open
akoeplinger opened this issue Jan 19, 2016 · 5 comments

Comments

@akoeplinger
Copy link
Contributor

One of my colleagues is getting this error in developer console and StashPop doesn't show up:

Error in event handler for (unknown): TypeError: Cannot read property 'length' of null
    at processTestFailures (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:670:44)
    at addTestFailureButtonsAndDescriptions (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:596:9)
    at reloadJenkins (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:210:5)
    at chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:140:13handler @ extensions::uncaught_exception_handler:8
15chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:303 StashPop:  Permission present.

@dpoeschl He didn't have the extension installed before, any idea why this would happen?

@dpoeschl
Copy link
Owner

Investigating, but possibly useful extra info:

  • URL they were visiting
  • surrounding developer console log

@akoeplinger
Copy link
Contributor Author

Ok, seems like he removed the default entries from "Non-default test suites:" and other lists because he thought they don't apply to us.

@dpoeschl
Copy link
Owner

Wow, that's interesting. Are their options screwed up?

image

@dpoeschl
Copy link
Owner

Ahh, yeah, I'm not coping well with empty entries there. 😦 Will fix up.

@dpoeschl
Copy link
Owner

They don't apply to you but are load bearing. 😉

@dpoeschl dpoeschl changed the title Bug: Cannot read property 'length' of null StashPop fails to load on PR pages with empty "Non-default test suites" options Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants