Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] SDK content test for Alpine is not comparing against linux-musl-x64 version of MS SDK tarball #3714

Closed
mthalman opened this issue Nov 3, 2023 · 3 comments
Assignees
Labels
area-testing Improvements in CI and testing

Comments

@mthalman
Copy link
Member

mthalman commented Nov 3, 2023

The SDK content test, when running in the Alpine build leg for 7.0, ends up comparing the linux-x64 version of the MS SDK tarball instead of the linux-musl-x64 version. This is not an accurate test. Since it's Alpine, it should be checking the content of the linux-musl-x64 version to ensure that content matches correctly.

This happens because the PortableRid MSBuild property is set to linux-x64 when it should be set to `linux-musl-x64. This is set correctly in the 6.0 branch:

https://github.com/dotnet/installer/blob/1b5e0e204956294804c290739a41e440d184d0af/src/SourceBuild/tarball/content/Directory.Build.props#L184

This was discovered while testing the changes in dotnet/installer#13074. Because PortableRid is set correctly there, it ends up using the linux-musl-x64 version of the tarball and exposed another unrelated issue.

Related to dotnet/installer#17324.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

[Triage] Please investigate if this applies to 8.0 as well when fixing.

@ellahathaway
Copy link
Member

ellahathaway commented Nov 16, 2023

8.0 does not currently include an alpine leg for the SDK content tests. However, the regex pattern for downloading the MSFT sdk matches that of 7.0 (i.e. uses linux instead of linux*). Therefore, in order to address #3715, this pattern will have to change to be linux*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Archived in project
Development

No branches or pull requests

3 participants