-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] source-build: support building runtime using non-portable runtime packages (backport of #75597) #77509
[release/6.0] source-build: support building runtime using non-portable runtime packages (backport of #75597) #77509
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@ViktorHofer I see you approved the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from one nit change, LGTM
Two tests are failing with a nuget problem. @ViktorHofer @ayakael Is the failure related to this change?
|
f237988
to
58d0516
Compare
I don't see how it could be related given that this change only expresses itself when |
…kages (backport of dotnet#75597)
58d0516
to
884c70d
Compare
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsBackport of #75597 Per @tmds
Customer impactFor distro maintainers, this removes the need for providing portable runtime packages to build non-portable runtime, thus we do not need to build runtime twice. This reduces our build time significantly. Testing
RiskLow, as it is already in
|
@carlossanlop can this change be merged into release/6.0? Is the branch already open? |
Backport of #75597
Per @tmds
Customer impact
For distro maintainers, this removes the need for providing portable runtime packages to build non-portable runtime, thus we do not need to build runtime twice. This reduces our build time significantly.
Testing
Risk
Low, as it is already in
main
, and only activates whenDotNetBuildFromSource=true