Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Proposal]: Ship IPNetwork downlevel for netstandard2.0 #88965

Closed
karelz opened this issue Jul 16, 2023 · 5 comments
Closed

[API Proposal]: Ship IPNetwork downlevel for netstandard2.0 #88965

karelz opened this issue Jul 16, 2023 · 5 comments
Assignees
@antonfirsov
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net
Milestone
8.0.0

Comments

@karelz
Copy link
Member

karelz commented Jul 16, 2023

See #79946 (comment)

We need decision from API review group - @stephentoub any thoughts when it might be decided?
@karelz karelz added area-System.Net blocking Marks issues that we want to fast track in order to unblock other important work api-ready-for-review API is ready for review, it is NOT ready for implementation labels Jul 16, 2023
@karelz karelz added this to the 8.0.0 milestone Jul 16, 2023
@ghost
Copy link

ghost commented Jul 16, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

See #79946 (comment)

We need decision from API review group - @stephentoub any thoughts when it might be decided?

Author: karelz
Assignees: -
Labels:

area-System.Net, blocking, api-ready-for-review
Milestone: 8.0.0

@karelz karelz mentioned this issue Jul 16, 2023
Closed
@stephentoub
Copy link
Member

We need decision from API review group - @stephentoub any thoughts when it might be decided?

What specific decision are you waiting on? The previous issue wasn't tagged to have it in any review queue.

If the question is whether to ship the type downlevel, I'd suggest defaulting to "no".

If the question is that you've already decided we need to and you're asking about package name, what is the proposed name?

@karelz
Copy link
Member Author

karelz commented Jul 18, 2023

Triage: If it is internal only in dotnet/extensions, then we do not need a downlevel package.
If it is public, then we should remove it from dotnet/extensions - if there are customers depending on it, we would ship it downlevel.

@terrajobst terrajobst added api-needs-work API needs work before it is approved, it is NOT ready for implementation and removed blocking Marks issues that we want to fast track in order to unblock other important work api-ready-for-review API is ready for review, it is NOT ready for implementation labels Jul 18, 2023
@terrajobst
Copy link
Member

terrajobst commented Jul 18, 2023 •
edited by dotnet-api-review bot
Loading

Video

@GrabYourPitchforks mentioned he received partner requests and will follow up with @antonfirsov to see if those got lost somewhere in mail.

@karelz
Copy link
Member Author

karelz commented Jul 20, 2023

Triage: We didn't see strong signal that it is needed. Closing
If it impacts a few customers, they can have a copy in their code for downlevel.

If there is more customer demand in future, we can reconsider.

@karelz karelz closed this as completed Jul 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antonfirsov antonfirsov

Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@stephentoub @terrajobst @karelz @antonfirsov