Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.12 VS hang on solution close #11044

Open
JanKrivanek opened this issue Nov 27, 2024 · 2 comments
Open

17.12 VS hang on solution close #11044

JanKrivanek opened this issue Nov 27, 2024 · 2 comments
Assignees

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Nov 27, 2024

Context

microsoft.visualstudio.projectservices.dll!Microsoft.VisualStudio.ProjectServices.DesignTimeBuildService.SolutionClosedEventHandler
https://prism.vsdata.io/failure/?query=ch%3Drelease%20r%3D17.12&eventType=hang&failureHash=cdfda8b0-fdb8-70cd-57c9-ad606708a21f
116 hits in the wild - ranks as top 14 hang

It seems related to previously fixed case: #10709 (comment) (thoug it seems slightly different)

FYI @davkean (pointed this case out)

@JanKrivanek
Copy link
Member Author

JanKrivanek commented Nov 27, 2024

It looks like we lost information about worker node shutdown and hence keep waiting for it (nodeId is 2 - pointing out to OutOfProcNode).
Otherwise the submission is completed with build cancelled result - so this is distinct from #10709

Image

@JanKrivanek
Copy link
Member Author

Through ComponentHost DI I got to the PID of the out of proc node that the BuildManager was waiting for - its: 10396:

Image

From the case ETL

Image

I can see that that that process did not terminate:

Image

So it might be possible that shutdown request wasn't even properly sent out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant