[iOS] Fix ShellContent Title Does Not Update at Runtime #26062
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/iOS 🍎
area-controls-shell
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This reverts commit ae6a031.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue occurred because the ShellContent title did not update dynamically in response to property changes. On iOS, real-time updates were not reflected as the Title property changes were not being observed.
Description of Change
Implemented dynamic title updates for ShellContent by subscribing to the PropertyChanged event. This ensures that any changes to the Title property are observed and updated in real-time, resolving the issue where the title did not reflect updates dynamically.
Regarding Test case
I did not add a new test case because the test cases added in PR for Windows and Android. These tests are applicable to my changes as well. I will only update the iOS image accordingly.
Issues Fixed
Fixes #26049
Tested the behaviour in the following platforms
Output Screenshot
BeforeFix.mov
AfterFix.mov