Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Flyout header spacing and dynamic height issue on iOS #25435

Closed
akhilvswoodplc opened this issue Oct 22, 2024 · 10 comments
Closed

Shell Flyout header spacing and dynamic height issue on iOS #25435

akhilvswoodplc opened this issue Oct 22, 2024 · 10 comments
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@akhilvswoodplc
Copy link

Description

Shell flyout header on iOS shows a spacing on the top between navigation bar and header. Also the Header height is not dynamically adjusting with the content bind to it after rendering the Shell layout

Image

On Android, this is working fine and layout expands with consistent spacing with dynamic content.

Steps to Reproduce

Add a shell layout and add a flyout header with some dynamic content bind to it. Set the dynamic data after rendering the Shell.

<Shell.FlyoutHeader> <VerticalStackLayout Padding="10" BackgroundColor="{Binding BackgroundColour}" MinimumHeightRequest="80" VerticalOptions="CenterAndExpand"> <Label FontSize="22" Style="{StaticResource BoldLabel}" Text="{Binding Session.UserName}" TextColor="White" /> <Label FontSize="Small" Text="{Binding Session.LevelE, Converter={StaticResource levelEConverter}}" TextColor="White" /> </VerticalStackLayout> </Shell.FlyoutHeader>

Link to public reproduction project repository

No response

Version with bug

8.0.91 SR9.1

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

@akhilvswoodplc akhilvswoodplc added the t/bug Something isn't working label Oct 22, 2024
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@akhilvswoodplc
Copy link
Author

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

This ticket is closed, but still not resolved

@PureWeen PureWeen added platform/iOS 🍎 area-controls-shell Shell Navigation, Routes, Tabs, Flyout s/needs-repro Attach a solution or code which reproduces the issue labels Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot added the s/no-recent-activity Issue has had no recent activity label Oct 28, 2024
@akhilvswoodplc
Copy link
Author

https://github.com/akhilvswoodplc/MauiShellIssueRepro

Added the repro sample in this repo.

As in the screenshot, there is a top spacing between statusbar and flyout header.
Also if the flyout header content is dynamically added, the bottom spacing is pushing the flyout item downwards keeping an empty space between.

Static content
Image

Dynamic content after page loaded
Image

@dotnet-policy-service dotnet-policy-service bot added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue s/no-recent-activity Issue has had no recent activity labels Oct 28, 2024
@ninachen03 ninachen03 added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Oct 29, 2024
@ninachen03
Copy link

This issue has been verified using Visual Studio 17.12.0 Preview 4(8.0.92 & 8.0.71). Can repro this issue at iOS platform.

@kubaflo
Copy link
Contributor

kubaflo commented Oct 29, 2024

Hi! I cannot replicate the header scaling issue on NET 9

When it comes to header spacing it looks more like a status bar issue which is not handled by MAUI, but by the Community toolkit

This is how the safe area should look like and it appears to me that MAUI correctly places the flyout within its safe area

@akhilvswoodplc
Copy link
Author

akhilvswoodplc commented Oct 29, 2024

Hi! I cannot replicate the header scaling issue on NET 9

When it comes to header spacing it looks more like a status bar issue which is not handled by MAUI, but by the Community toolkit

This is how the safe area should look like and it appears to me that MAUI correctly places the flyout within its safe area

The issue comes when you have a different statusbar color. The image shows just white color. When you change that, the spacing is evident.

@kubaflo
On this "When it comes to header spacing it looks more like a status bar issue which is not handled by MAUI, but by the Community toolkit" : I dont think it is Statusbar issue, because on normal contentpage, there is no spacing issue. The issue comes only with flyout header

@akhilvswoodplc
Copy link
Author

@kubaflo

The issue comes when you have a different statusbar color. The image shows just white color. When you change that, the spacing is evident.
On this "When it comes to header spacing it looks more like a status bar issue which is not handled by MAUI, but by the Community toolkit" : I dont think it is Statusbar issue, because on normal contentpage, there is no spacing issue. The issue comes only with flyout header

@kubaflo
Copy link
Contributor

kubaflo commented Oct 29, 2024

@akhilvswoodplc By I cannot relocate it on Net9 I meant the scaling issue not the spacing. But I still think that the status flyout header is correctly placed (I might be wrong though)

This is similar to #24972

@jsuarezruiz
Copy link
Contributor

@jfversluis Could we transfer this issue to the Community Toolkit repo? I think have more sense there.

@jfversluis
Copy link
Member

This is indeed something for the .NET MAUI CommunityToolkit.

Already reported here: CommunityToolkit/Maui#2287 so please track the progress there. Closing this one here for now.

@jfversluis jfversluis closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants