Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and compare linux-musl-x64 MSFT sdk #17823

Merged

Conversation

ellahathaway
Copy link
Member

Addresses dotnet/source-build#3714

This PR:

Azdo pipeline run with these changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=2317704&view=results

@ellahathaway ellahathaway requested a review from a team as a code owner November 16, 2023 22:31
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this is doing what it's supposed to yet. Looking at the output in the .trx file for the Alpine leg, I see this: Executing: tar tf /BlobArtifacts/dotnet-sdk-7.0.115-linux-x64.tar.gz. That would indicate the test is still referencing the linux-x64 tarball instead of the linux-musl-x64 tarball.

@ellahathaway
Copy link
Member Author

ellahathaway commented Nov 17, 2023

Looking at the output in the .trx file for the Alpine leg, I see this: Executing: tar tf /BlobArtifacts/dotnet-sdk-7.0.115-linux-x64.tar.gz

I completely missed this. Thank you for pointing it out! These changes should be addressed in 1538ad0.

The current issue I'm facing is that the pipeline is setting the PortableRid to linux-x64 instead of linux-musl-x64. As a result, this pipeline run fails the SDK content test because the RID is not being parsed out correctly. I will update this PR once I have determined the cause of this.

Edit: Confirmed that the changes work (had to do a run of the official installer ci on my branch and consume that run in the tarball pipeline): https://dev.azure.com/dnceng/internal/_build/results?buildId=2319692&view=logs&j=da6acb1f-3c5f-5ef6-22ae-5fcf343f6bd9&t=91f6af53-1a55-52eb-e2a8-794ecfaa0886

@ellahathaway ellahathaway merged commit 61a7ec7 into dotnet:release/7.0.1xx Nov 27, 2023
18 checks passed
@ellahathaway ellahathaway deleted the compare-alpine-linux-musl branch November 27, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants