Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Psalm with PHPStan ? #324

Closed
arhimede opened this issue Oct 16, 2024 · 5 comments
Closed

Replace Psalm with PHPStan ? #324

arhimede opened this issue Oct 16, 2024 · 5 comments
Assignees

Comments

@arhimede
Copy link
Member

"use one static analysis tool and Doctrine projects will use PHPStan going forward. For now Psalm checks will be removed from repositories over the next weeks.

This is mainly because PHPStan has outpaced Psalm in depth and quality in the last few years and it feels unlikely that Psalm can point to a problem that PHPStan did not detect before. If in the future Psalm catches up to PHPStan we may reconsider adding it."

@arhimede
Copy link
Member Author

@MarioRadu maybe we will need to create a separate library
phpstan-mezzio
to handle custom mezzio logic

@arhimede
Copy link
Member Author

@arhimede
Copy link
Member Author

phpstan/phpstan#8986

@arhimede
Copy link
Member Author

so the decision of Dotkernel TSC was to swith to phpstan and drop psalm
and create a *.neo files with temporary exceptions

https://github.com/doctrine/orm/blob/3.3.x/phpstan.neon
https://github.com/doctrine/orm/blob/3.3.x/phpstan-params.neon

Level 5 for the moment

@alexmerlin
Copy link
Member

Implemented in #348 #349 #350 and #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants