Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sibling selectors before check if class is used on page #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agubler
Copy link
Member

@agubler agubler commented Jul 18, 2022

Type: bug

The following has been addressed in the PR:

Description:

Selectors using ~ or + are not added to the BTR output even if the page uses the class. This change removes + and ~ before checking against the pages classes.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #342 (c8e7c89) into master (a6dcaf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          54       54           
  Lines        2618     2618           
  Branches      715      715           
=======================================
  Hits         2239     2239           
  Misses        379      379           
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 93.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dcaf4...c8e7c89. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants