Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/main css in main chunk #335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KaneFreeman
Copy link
Member

Type: bug

The following has been addressed in the PR:

Description:
Bootstrap plugin will now import the main.css file when the path is provided from cli-build-app (aka main.css exists).

Resolves dojo/cli-build-app#228

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #335 (8801981) into master (181c774) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   85.43%   85.41%   -0.03%     
==========================================
  Files          54       54              
  Lines        2602     2605       +3     
  Branches      706      707       +1     
==========================================
+ Hits         2223     2225       +2     
- Misses        379      380       +1     
Impacted Files Coverage Δ
src/bootstrap-plugin/async.js 0.00% <0.00%> (ø)
src/bootstrap-plugin/BootstrapPlugin.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181c774...8801981. Read the comment docs.

@agubler agubler removed their request for review May 22, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS from main.css is extracted to bootstrap.css
1 participant