Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack bundle analyzer #263

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Apr 24, 2020

Type: feature

The following has been addressed in the PR:

Description:

  • Refactor analyzer to functions
  • Change from a webpack plugin to a general utility
  • Add support for finding the size of code belonging to specific node modules included in a
    specific bundle
  • Return a map of chunk names to bundle data from analyzer
  • Update logic to fix scenarios where parsing failed or was aborted unnecessarily.

Needed to address dojo/cli-build-app#390

@maier49 maier49 mentioned this pull request Apr 25, 2020
4 tasks
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a023379). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage          ?   85.93%           
=========================================
  Files             ?       49           
  Lines             ?     2296           
  Branches          ?      604           
=========================================
  Hits              ?     1973           
  Misses            ?      323           
  Partials          ?        0           
Impacted Files Coverage Δ
src/main.ts 100.00% <ø> (ø)
src/webpack-bundle-analyzer/AnalyzeBundles.ts 0.00% <ø> (ø)
src/webpack-bundle-analyzer/analyzer.ts 95.74% <ø> (ø)
src/webpack-bundle-analyzer/parseUtils.ts 57.03% <ø> (ø)
src/webpack-bundle-analyzer/viewer.ts 89.74% <ø> (ø)
src/build-time-render/BuildTimeRender.ts 94.96% <0.00%> (ø)
src/i18n-plugin/I18nPlugin.ts 100.00% <0.00%> (ø)
src/build-time-render/blocks.js 0.00% <0.00%> (ø)
src/bootstrap-plugin/common.js 0.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a023379...1343095. Read the comment docs.

* Refactor to functions
* Change from a webpack plugin to a general utility
* Add support for finding the size of node modules
* Return a map of chunks to bundle data from analyzer
Copy link
Member

@agubler agubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maier49 maier49 merged commit 599248b into dojo:master Oct 1, 2020
@maier49 maier49 deleted the update-analyzer branch October 1, 2020 18:23
@matt-gadd
Copy link
Contributor

backing this out as the other side was not landed, now has conflicts and is stopping us from landing additional work.

matt-gadd added a commit that referenced this pull request Dec 2, 2020
matt-gadd added a commit that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants