Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle composable bake attributes #503

Open
crazy-max opened this issue Nov 26, 2024 · 0 comments · May be fixed by #514
Open

Handle composable bake attributes #503

crazy-max opened this issue Nov 26, 2024 · 0 comments · May be fixed by #514
Labels
kind/enhancement New feature or request

Comments

@crazy-max
Copy link
Member

Atm we expect csv values when parsing the raw definition:

export interface Target {
args?: Record<string, string>;
attest?: Array<string>;
'cache-from'?: Array<string>;
'cache-to'?: Array<string>;
context: string;
contexts?: Record<string, string>;
dockerfile: string;
'dockerfile-inline'?: string;
labels?: Record<string, string>;
'no-cache'?: boolean;
'no-cache-filter'?: Array<string>;
output?: Array<string>;
platforms?: Array<string>;
pull?: boolean;
secret?: Array<string>;
'shm-size'?: string;
ssh?: Array<string>;
tags?: Array<string>;
target?: string;
ulimits?: Array<string>;
}

With work being done to handle composable bake attributes in next Buildx 0.19.0 (docker/buildx#2758), we need to adapt and handle them correctly here.

cc @tonistiigi @jsternberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant