Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestLightGBMIntegration::test_sparse_categorical_model test fails with MSVC and Apple Clang #13

Open
hcho3 opened this issue Jun 19, 2019 · 0 comments

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Jun 19, 2019

tests/python/test_lightgbm_integration.py::TestLightGBMIntegration::test_sparse_categorical_model test generates code with high-cardinality categorical splits. For such splits, Treelite currently generates massively long if conditions. This doesn't cause issue with GCC, but crashes Apple Clang and freezes MSVC.

TODO. Implement a more compact representation for categorical splits.

hcho3 referenced this issue in dmlc/treelite Oct 8, 2019
* More exhaustive method to locate vcvarsall.bat; mark some tests as non-Windows

* Do not produce empty array literals, as MSVC does not allow them

* Do not use gcc on Windows

* Re-order array definitions before quantize() function

* Skip test_sparse_categorical_model() test on Windows, see #100

* Free predictor objects between multiple tests, to avoid locking DLL files

* Run unit tests on Windows

* Replace *.whl extension with *.zip

* Fix syntax error in PowerShell script

* Fix lint

* Use correct version of MSVC

* Add conda to PATH

* Install pytest and other packages

* Expand short paths on Windows

* Create temp directory locally

* Fix lint

* Debugging hung tests in Windows

* Remove LETOR from testing on Windows

* Remove verbose printing
@hcho3 hcho3 transferred this issue from dmlc/treelite May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant