Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] config parsing fails on initial run #478

Closed
guseggert opened this issue Nov 9, 2024 · 6 comments
Closed

[BUG] config parsing fails on initial run #478

guseggert opened this issue Nov 9, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@guseggert
Copy link

Describe the bug
I installed gh-dash with gh extension install dlvhdr/gh-dash and ran gh dash, it crashes due to config parsing errors:

2024-11-09T10:32:38-05:00 FATA <ui/ui.go:107> Reading config file: failed parsing config file location=""
                           err=
                                 │ failed parsing config.yml: Key: 'Config.theme.colors.Inline.text.secondary' Error:Field validation for 'secondary' failed on the 'hexcolor' tag
                    │ Key: 'Config.theme.colors.Inline.text.inverted' Error:Field validation for 'inverted' failed on the 'hexcolor' tag
                                                          │ Key: 'Config.theme.colors.Inline.text.faint' Error:Field validation for 'faint' failed on the 'hexcolor' tag
          │ Key: 'Config.theme.colors.Inline.text.warning' Error:Field validation for 'warning' failed on the 'hexcolor' tag
                                              │ Key: 'Config.theme.colors.Inline.text.success' Error:Field validation for 'success' failed on the 'hexcolor' tag
  │ Key: 'Config.theme.colors.Inline.background.selected' Error:Field validation for 'selected' failed on the 'hexcolor' tag
                                              │ Key: 'Config.theme.colors.Inline.border.primary' Error:Field validation for 'primary' failed on the 'hexcolor' tag
    │ Key: 'Config.theme.colors.Inline.border.secondary' Error:Field validation for 'secondary' failed on the 'hexcolor' tag
                                              │ Key: 'Config.theme.colors.Inline.border.faint' Error:Field validation for 'faint' failed on the 'hexcolor' tag

And also leaves my terminal in a messed up state (no text cursor, newlines messed up, etc.).

To Reproduce
Steps to reproduce the behavior:

  1. gh extension install dlvhdr/gh-dash
  2. gh dash

Expected behavior
Not sure, I wanted to try it out, I'd imagine crashing is not the expected behavior for new users though.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: MacOS 15.0.1 (Sequoia)
  • I also tried this in an Ubuntu docker image, and on a Linux laptop (bluefin), same error
$ gh --version
gh version 2.59.0 (2024-10-15)
@guseggert guseggert added the bug Something isn't working label Nov 9, 2024
@cosgroveb
Copy link
Contributor

I'm having the same issue

@cosgroveb
Copy link
Contributor

Not sure, I wanted to try it out, I'd imagine crashing is not the expected behavior for new users though.

@guseggert it's a pretty cool tool, to be honest. Seems like the bleeding edge releases sometimes have crashes unfortunately. Right now, for me gh extension install dlvhdr/gh-dash --pin v4.5.4 is working well and is a fairly recent release. Good luck.

@dlvhdr
Copy link
Owner

dlvhdr commented Nov 9, 2024

Hmm yeah it's probably because I don't have really any tests, given it's a side project. I should add some though, to prevent this. Anyway, will look into it. I suspect it happens when you don't have a config

@dlvhdr
Copy link
Owner

dlvhdr commented Nov 9, 2024

Should be fixed by #480. Please verify once release is live.

@dlvhdr dlvhdr closed this as completed Nov 9, 2024
@cosgroveb
Copy link
Contributor

cosgroveb commented Nov 9, 2024

Hmm yeah it's probably because I don't have really any tests, given it's a side project. I should add some though, to prevent this. Anyway, will look into it. I suspect it happens when you don't have a config

Hey no worries didn't mean my comment as any kind of criticism. Really enjoying gh dash

@guseggert
Copy link
Author

Should be fixed by #480. Please verify once release is live.

Works great now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants