Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The sidebar does not render all the contents if the content includes a very long line #412

Open
kyu08 opened this issue Aug 9, 2024 · 3 comments · May be fixed by #466
Open

[BUG] The sidebar does not render all the contents if the content includes a very long line #412

kyu08 opened this issue Aug 9, 2024 · 3 comments · May be fixed by #466
Labels
bug Something isn't working

Comments

@kyu08
Copy link
Contributor

kyu08 commented Aug 9, 2024 •
edited
Loading

Describe the bug

The sidebar does not render properly if the content includes a very long line.
This makes approve textarea not be able to seen.

To Reproduce

Steps to reproduce the behavior:

  1. Select a PR including a very long line (e.g. fix(deps): update rust crate uuid to v1.10.0 - autoclosed kyu08/fzf-make#295 )
  2. Scroll to the bottom by ctrl + d

Expected behavior

All the contents is rendered.

Screenshots

The sidebar can't all the contents. (The last line of the comment is This is the last line. But it is not rendered.)

image

Environments (please complete the following information):

  • OS: macOS
  • Commit hash: c524f60c308d

How to resolve

I submitted a PR to charmbracelet/bubbles to fix this problem by fixing height calculation method. charmbracelet/bubbles#578
So if the PR is merged, bumping the version resolves this issue.
@kyu08 kyu08 added the bug Something isn't working label Aug 9, 2024
@kyu08 kyu08 changed the title [BUG] The sidebar does not render properly if the content includes a very long line [BUG] The sidebar does not render all the contents if the content includes a very long line Aug 9, 2024
@Garfeild
Copy link

Garfeild commented Oct 7, 2024

Looking forward for this to be resolved! 🔥

@Garfeild Garfeild linked a pull request Oct 17, 2024 that will close this issue
Open
@Garfeild
Copy link

Garfeild commented Oct 17, 2024 •
edited
Loading

@kyu08 Can you check my PR #466 whether it fixes issue for you?

@kyu08
Copy link
Contributor Author

kyu08 commented Nov 4, 2024 •
edited
Loading

@Garfeild
I'm sorry for the late reply.
Good job! It seems fixed for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: apply wrapping with lipgloss Garfeild/gh-dash
2 participants
@Garfeild @kyu08