-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Publish version/release on pkg.go.dev #392
Comments
See https://go.dev/doc/modules/publishing to publish your module on https://pkg.go.dev |
I believe the PR #393 I just submitted is the correct way to get those systems to kick in and pull the latest. Can't say I've delved into anything v2 and beyond tbh, thinking about it. (On another note; does anyone else think the sheer number of specific imports across so many files is a bit of a smell?) |
I'm not that familiar with how go manages packages. When I bump a major version will I need to update all those imports again? |
Honestly, they made a bunch of changes after I first tried the language out on a couple toy projects and returning to it to see how it has come along just recently. The whole packages deal is in that gap, but as I understand it for backwards compatibility you don't specify There are other options to what I did tbh; you could also include version 1 as a dependency in Does come with the advantage that you can choose to keep supporting older versions with feature and/or bug updates and pushing new minor/patch tags more easily (kinda). Probably only ever worth bothering with if you're writing something with LTS versions, or that people on certain more glacial distros, other OS entirely, etc. have to use. Can't help you on the go-releaser question tbh as I have no idea what that even is. I'm not even sure that this might not have been possible with I will note as well though that there were an awful lot more specific dependencies on sub-packages and sub-sub-packages than I expected going in. It's very neat on disk and in the imports list, but then you have a bunch of unqualified identifiers in the code itself. It's a style matter ultimately I'm sure, but I'm not sure personally having everything so intimately aware of the internals of everything else is that important, and being able to refer to Ultimately I guess it's a question of how you like to view things; should To be clear, I'm staying as far away from the notion that the flatter approach I'd typically at least begin with is a better approach in any way as I possibly can. In fact, my official position is that I'm lazy and this looks exhausting to me. =P |
I should definitely also point out that Go, of course, has opinions on how the versioning should all be approached: Go Modules: v2 and Beyond |
Hmm seems like I need to publish a new major for this to take effect. |
@Omnikron13 You're right: to fix this issue, @dlvhdr I don't know if it's possible to update the module version with goreleaser when you are bumping a major version for the project. I think you only need to publish a new release (v4.1.3 or v4.2.0) with this fix to publish it on https://pkg.go.dev |
With the latest release, the $ go list -m github.com/dlvhdr/gh-dash/v4@latest
github.com/dlvhdr/gh-dash/v4 v4.3.0 |
I'm trying to package
gh-dash
for OpenBSD to import it in the official ports tree.The port infrastructure on OpenBSD for Go projects needs to get version/infos from pkg.go.dev => get
MOD_NAME
and latest published versionMOD_VERSION
.On pkg.go.dev, these infos are not up to date => https://pkg.go.dev/github.com/dlvhdr/gh-dash
Please could you published the latest version v4.1.2 on pkg.go.dev and for each future release ?
The text was updated successfully, but these errors were encountered: