16.0 fix mcurr tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
etobella
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etobella
This PR fix the failing test of this PR : OCA#694
The failing tests made me see that were still basic bugs, I had to do quite some change again.
Now tests are fixed, I still need to add tests for some basic use cases of multi-currency management.
Still, I am quite sure there will still exist issue with some less comon cases.
Also, I saw that the mutli-currency reconciliation was also broken when trying to do it directly from account move lines, because most of the implemented logic is on
account.bank.statement.lineBut I don't intend to work on that part, at least not in the short term...
let's talk a bit about this PR tomorrow if you have some time.
I'll try to add some tests tomorrow also if I have the time !