Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url encoding issues #25

Open
852Kerfunkle opened this issue Apr 22, 2022 · 1 comment
Open

Url encoding issues #25

852Kerfunkle opened this issue Apr 22, 2022 · 1 comment

Comments

@852Kerfunkle
Copy link
Contributor

852Kerfunkle commented Apr 22, 2022

Some IPFS links won't resolve because the url isn't encoded properly.

For example ipfs://bafybeid5xl7cwdaelgh2rrxeicul6v7xbuwvtgiywklui43todymiyxx3y/TZLAND#247_FINALE.glb (just imagine this could be a json file for the sake of this ticket) will fail to fetch because the # isn't url encoded. Filenames containing spaces appear to work fine, though.

Tried fixing this but I can't quite figure out where that goes wrong and adding additional url encoding causes spaces to be double url encoded (%2520).

Thanks!

@852Kerfunkle
Copy link
Contributor Author

852Kerfunkle commented Apr 23, 2022

Ok, so part of the problem is on my end (urls in metadata not being properly encoded), but there's definitely also an issue here: unencoded urls not being encoded before requests.

I suppose a possible solution would be to url decode links and then url encode them again to make sure to catch half, badly or un-encoded urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant