-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETPROD-3583] Added name param in ListOption to get resource by name #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many endpoints that use the shared ListOptions
struct do not support filtering by name, it might be a bit misleading for users to include it here. I think it might be better to follow the pattern already used by Droplets and domain records by adding a new ListByName
method to the certificate service. e.g.:
Line 20 in d5fe4d2
ListByName(context.Context, string, *ListOptions) ([]Droplet, *Response, error) |
Line 22 in d5fe4d2
RecordsByName(context.Context, string, string, *ListOptions) ([]DomainRecord, *Response, error) |
Thoughts?
@andrewsomething I have made changes as requested. pls review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
NETPROD-3583