Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep v1.104.0 release. #639

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Prep v1.104.0 release. #639

merged 1 commit into from
Oct 10, 2023

Conversation

andrewsomething
Copy link
Member

Cuts a new release with the recent changes so that we can get them pulled into doctl

Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #637 a breaking change?

@andrewsomething
Copy link
Member Author

@bentranter I do not believe so. At first blush, I thought it might be as well. Though the tests all pass as is despite not using the new typed const, e.g.

https://github.com/mikesmithgh/godo/blob/6c7a058657910fe9997ca44b946a5528ee4d7856/uptime_test.go#L314

Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change out, #637 won't break the API 👍

@andrewsomething andrewsomething merged commit d6e1543 into main Oct 10, 2023
7 checks passed
@andrewsomething andrewsomething deleted the asb/v-1-104-0 branch October 10, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants