Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs audit: SSH and SSH Keys #1492

Closed
wants to merge 3 commits into from
Closed

Docs audit: SSH and SSH Keys #1492

wants to merge 3 commits into from

Conversation

dbrian57
Copy link
Contributor

Updates and clarifies doc strings for SSH and SSH Key commands. Also add examples for each command.

@dbrian57 dbrian57 added the docs label Dec 31, 2023
MrCuPper

This comment was marked as off-topic.

MrCuPper

This comment was marked as off-topic.

danaelhe
danaelhe previously approved these changes May 14, 2024
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once merge conflicts are resolved 👍

thank you!

Copy link

gitguardian bot commented Nov 22, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14553403 Triggered Generic Password b117942 vendor/golang.org/x/tools/internal/gocommand/invoke.go View secret
9440732 Triggered PostgreSQL Credentials b117942 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials b117942 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials b117942 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials b117942 integration/database_connection_pool_test.go View secret
9440732 Triggered PostgreSQL Credentials b117942 integration/database_connection_pool_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dbrian57 dbrian57 closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants