do not link against OBJECT library directly; fixes #33

dftlibs · May 3, 2019 · 636dac3 · 636dac3
1 parent 5dab817
commit 636dac3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/numgrid/CMakeLists.txt b/numgrid/CMakeLists.txt
@@ -33,6 +33,16 @@ add_library(
     $<TARGET_OBJECTS:numgrid-objects>
   )
 
+# this is an ugly hack to make the unit tests link
+# a nicer solution would be not to duplicate this info
+# since the target dependencies are already expressed
+# in numgrid-objects
+target_include_directories(
+  numgrid-shared
+  PUBLIC
+    ${CMAKE_CURRENT_BINARY_DIR}
+  )
+
 set_target_properties(
   numgrid-shared
   PROPERTIES
@@ -61,7 +71,7 @@ if(ENABLE_FC_SUPPORT)
   target_link_libraries(
     numgrid_fortran_bindings
     PRIVATE
-      numgrid-objects
+      numgrid-shared
     )
 endif()
 

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -33,7 +33,7 @@ target_include_directories(
 target_link_libraries(
   cpp_test
   PRIVATE
-    numgrid-objects
+    numgrid-shared
     gtest_main
   )
 
@@ -52,7 +52,7 @@ if(ENABLE_FC_SUPPORT)
     target_link_libraries(
       fortran_${_test}
         numgrid_fortran_bindings
-        numgrid-objects
+        numgrid-shared
       )
 
     add_test(