New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat fix for older numpy versions #517

Merged

dfm merged 3 commits into dfm:main from MuellerSeb:numpy_exceptions_compat

Apr 19, 2024

Contributor

MuellerSeb commented Apr 19, 2024 •

edited

Loading

Fixes: #518 #515 (comment)

Before numpy 1.25, there was no exceptions namespace in numpy: https://numpy.org/doc/1.25/release/1.25.0-notes.html#numpy-now-has-an-np-exceptions-namespace

This PR fixes this for older numpy versions by importing VisibleDeprecationWarning from top level if exceptions is not present.

MuellerSeb and others added 3 commits

April 19, 2024 10:13


          Compat fix for older numpy versions

c4426fe


          Adding test environment for old numpy versions

309ed30


          Fixing lint

a7d69e5

Owner

dfm commented Apr 19, 2024

Thanks @MuellerSeb!! I've added a job to the tests workflow which should test this issue. As soon as that finishes running I'll merge.

dfm merged commit 9c5f59b into dfm:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet