feat(frontend): fallback for non-working index canisters #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
commented
Nov 26, 2024
|
|
||
| // In case of error, we start the listener again, but only with the ledgerCanisterId, | ||
| // to make it request only the balance and not the transactions | ||
| restartWorkerWithLedgerOnly(); |
There was a problem hiding this comment.
@peterpeterparker as discussed; do you think it is too much to have an internal function? I would not externalize it, just because I need to pass all props (worker, ledger, env)
peterpeterparker
approved these changes
Nov 26, 2024
| }) => { | ||
| icTransactionsStore.reset(tokenId); | ||
|
|
||
| // We get transactions and balance for the same end point therefore if getting certified transactions fails, it also means the balance is incorrect. | ||
| balancesStore.reset(tokenId); | ||
|
|
||
| if (silent) { | ||
| // We print the error to console just for debugging purposes | ||
| console.error(`${get(i18n).transactions.error.loading_transactions}:`, err); |
There was a problem hiding this comment.
console.warn if it's just for debugging purpose?
|
|
||
| // In case of error, we start the listener again, but only with the ledgerCanisterId, | ||
| // to make it request only the balance and not the transactions | ||
| restartWorkerWithLedgerOnly(); |
AntonioVentilii
deleted the
feat(frontend)/fallback-for-non-working-index-canisters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It may happen that an ICRC token has an Index Canister but it is not working. For example, it is out of cycles.
In those cases, we don't want to show an error anymore, but leverage the same wallet service used for tokens without Index Canister.
That means, that in those cases, we will just fetch the balance, and show an explanatory warning for not having the transacitons.
Changes
onLoadTransactionsErrorto accept a fallback function.Note
The changes in the UI will be done with:
Tests
I simulated a wrong index canister in the local replica for ckSepoliaUSDC. In the video we can see how I switch between the correct Index canister and the wrong one, back and forth.
Screen.Recording.2024-11-26.at.13.16.36.mov