Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend GitHub Apps for GitHub Connector over OAuth Apps #163

Open
evandam opened this issue Feb 9, 2024 · 0 comments
Open

Recommend GitHub Apps for GitHub Connector over OAuth Apps #163

evandam opened this issue Feb 9, 2024 · 0 comments

Comments

@evandam
Copy link

evandam commented Feb 9, 2024

Hey folks 👋

While setting up Dex in a few different environments, I found it pretty tedious that I had to create a new GitHub OAuth App since there's a limitation of one callback URL per app while following the GitHub Connector docs

I noticed in GitHub's docs they mention considering using a GitHub App over a GitHub OAuth App, as both can do OAuth 2.0 flows.

I switched my Dex configs to point to a GitHub App, and there are some advantages like being able to have up to 10 callback URLs per app now.

However, instructions are a little different, and you need to grant the app some additional scopes:

  • Organization Permissions > Members: Read-only
  • Account Permissions > Email Addresses: Read-only
  • Account Permissions > Profile: Read and write

I'm not entirely sure why the Profile scope is needed, and there's no read-only option, which is a bit of a bummer, but it works anyway.

I know there are tradeoffs with this approach, but maybe it's worth mentioning in the Dex docs if you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant