fix(routing): correct useFilterWithQS usage #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Tested locally, looks good. We'll need to publish a new veda-ui library version to verdaccio and update it in the Next.js package.json (I'll do it once we merge the other change I did)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NASA-IMPACT/veda-ui#1270, we updated the interface of
useFilterWithQSby removing the requirement to passrouter.navigateto the hook.@dzole0311, you already tested this while reviewing the upstream PR. Could you give this a quick look?