[#1238] Use the new derived atom for dataset hydration #17
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
changed the title
dzole0311
changed the title
vgeorge
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
@dzole0311 I followed the steps, this is working as described 👍
dzole0311
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Nov 25, 2024
**Related Ticket:** #1238 **Related Next.js PR:** developmentseed/next-veda-ui#17 ### Description of Changes - Removed dependency on static datasets (veda_faux_module_datasets) when reconciling datasets from URL params in E&A - Created `externalDatasetsAtom` to store datasets from host applications (eg Next.js) - Modified `datasetLayersAtom` to use external datasets instead of the bundled static datasets from VEDA UI ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing VEDA UI 1. Open E&A and select a few datasets 2. Once they are loaded, refresh the page 3. Verify that the datasets still load without issues, no errors are thrown Next.js 1. Same as for the VEDA UI above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test locally using the related VEDA UI pull request + description and test instructions: NASA-IMPACT/veda-ui#1266