Handle some obscure cases #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cache path doesnt exist, Path operations on the top-level archive file fail. Hard-code the expected result to match the results when the cache is populated. Add prevent use of `ArchivePath.open` and `ArchiveStream.read` on the top level archive file. Also prevent unsupported open write mode. Fixes dephell#15 Related to dephell#4
jayvdb
commented
Dec 28, 2019
| # project | ||
| from dephell_archive import ArchivePath | ||
|
|
||
|
|
||
| sdist_path = Path(__file__).parent / 'requirements' / 'sdist.tar.gz' | ||
|
|
||
|
|
||
| def test_toplevel(tmpdir): |
There was a problem hiding this comment.
happy to duplicate these over in test_path_zip, or create a new test file test_path_meta.py/test_path_meta.py for tests which do not depend on the tar/zip implementation.
|
Good catch! I'm going to handle the same when the file is in the cache, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cache path doesnt exist, top-level path
operations fail.
Also prevent open write mode.
Fixes #15
Related to #4