Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write support #4

Open
jayvdb opened this issue Dec 25, 2019 · 1 comment
Open

Write support #4

jayvdb opened this issue Dec 25, 2019 · 1 comment

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Dec 25, 2019

I dont see write support

Also it appears that mode w is not recognised - it should cause a NotImplementedError at the moment until write support is implemented.

https://pypi.org/project/xopen/ has pretty good write support.
@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 26, 2019 •
edited
Loading

My motivation for wanting it was to build test cases for jerith/landinggear#3

But the same would be quite beneficial for dephell tests in general ; instead of storing specific archives in the repos for testing, those scenarios could be easily built by creating archives which exhibit the various curious cases needing tests.

Note that I didnt find any part of wheel which allowed easy creation of a WHEEL file outside of setuptools, so I needed to create my own fake logic in above PR which could be the basis for a real generator.

@jayvdb jayvdb mentioned this issue Dec 28, 2019
Merged
jayvdb added a commit to jayvdb/dephell_archive that referenced this issue Dec 28, 2019
@jayvdb
Handle some obscure cases
1e72a44 
When the cache path doesnt exist, Path operations on the top-level
archive file fail.  Hard-code the expected result to match the
results when the cache is populated.
Add prevent use of `ArchivePath.open` and `ArchiveStream.read`
on the top level archive file.

Also prevent unsupported open write mode.

Fixes dephell#15
Related to dephell#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb