Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two archives can overwrite each others cache entries #17

Open
jayvdb opened this issue Dec 28, 2019 · 1 comment
Open

Two archives can overwrite each others cache entries #17

jayvdb opened this issue Dec 28, 2019 · 1 comment

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Dec 28, 2019

As the archive name / hash isnt in the cache directory naming, two different archives with the same internal paths can overwrite each other.

This is especially problematic for two wheels of different versions/platforms of the same package, as they are likely to have the same directory name for the installed code.
i.e. dephell-0.1.0 and dephell-0.2.0 wheels both contain dephell/.

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 28, 2019

I guess that dephell is doing cache conflict avoidance elsewhere.
It would be nice to bring it into this project, or otherwise document (more clearly) that the caller needs to provide a unique cache dir for each archive.

I actually like the current mode for the project I am working on, as it is only sdists which all have a unique-ish top level dir in the sdist.
So if this is going to be fixed, it would be great to support a few cache modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant