You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function list_log_files generates ParsedLogPath by parsing file paths in _delta_log. Parsing may fail if there is an unexpected file path. Crc files are commonly written to _delta_log by delta implementations. We must ensure that crc files do not cause log file listing to fail. They must instead be ignored.
Describe the functionality you are proposing.
Add a test to ensure that crc files are ignored. This test must ensure that the following example _delta_log directory does not cause list_log_files to fail:
Please describe why this is necessary.
The function
list_log_files
generatesParsedLogPath
by parsing file paths in_delta_log
. Parsing may fail if there is an unexpected file path. Crc files are commonly written to_delta_log
by delta implementations. We must ensure that crc files do not cause log file listing to fail. They must instead be ignored.Describe the functionality you are proposing.
Add a test to ensure that crc files are ignored. This test must ensure that the following example
_delta_log
directory does not causelist_log_files
to fail:Additional context
You can find the function in question at
kernel/src/log_segment.rs
. The test file for log segment is inkernel/src/log_segmnt/tests.rs
.The text was updated successfully, but these errors were encountered: