This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Remove terminating pods from endpoints #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tjamet
force-pushed
the
master
branch
3 times, most recently
from
44639e6
to
b67739c
Compare
The standard endpoint controller removes, by default, terminating pods from an endpoint: kubernetes/kubernetes@2aaf8bd#diff-a1a9c0efe93384ed9a010e65e8ad4604R316 This behaviour let the service clients time to react to stop sending traffic to the terminating pods while finishing processing current requests, as pods in "terminating" state are technically still able to accept connections and handle requests. It allows to smoothly replace the pods by the activator when all pods are entering the terminating state, for the reason described above.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 40.32% 40.32%
=======================================
Files 14 14
Lines 977 977
=======================================
Hits 394 394
Misses 554 554
Partials 29 29Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard endpoint controller removes, by default, terminating pods
from an endpoint: kubernetes/kubernetes@2aaf8bd#diff-a1a9c0efe93384ed9a010e65e8ad4604R316
This behaviour let the service clients time to react to stop sending
traffic to the terminating pods while finishing processing current
requests, as pods in "terminating" state are technically still able to
accept connections and handle requests.
It allows to smoothly replace the pods by the activator when all pods
are entering the terminating state, for the reason described above.
Fixes: #30