Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retries for failed Requests #241

Open
jpvajda opened this issue Mar 15, 2024 · 2 comments
Open

Improve retries for failed Requests #241

jpvajda opened this issue Mar 15, 2024 · 2 comments
Labels
enhancement New feature or request low priority Do these last...

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Mar 15, 2024

Issue

Performing retries on failed Rest requests could be easier.

A customer using the JS SDK is getting errors ETIMEDOUT and ECONNRESET , and they're wondering if those errors could be caught with a LiveTranscriptionEvents.Error . We can consider this for the .NET SDK as well.

Acceptance Criteria

  • For Rest Requests make it easy to implement retries
  • For Streaming Requests make it easy to implement retries
@jpvajda jpvajda added the enhancement New feature or request label Mar 15, 2024
@jpvajda
Copy link
Contributor Author

jpvajda commented Mar 15, 2024

@dvonthenen

@davidvonthenen davidvonthenen added this to the .Net SDK 4.1 milestone Apr 17, 2024
@davidvonthenen davidvonthenen added the low priority Do these last... label Nov 7, 2024
@davidvonthenen
Copy link
Contributor

This is a Go specific implementation:
https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/client/common/v1/websocket.go#L163-L170

We should attempt to reconnect on an error unless the user calls Stop/Finish on the websocket meaning we are done using the websocket object until we call connect again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Do these last...
Projects
None yet
Development

No branches or pull requests

2 participants