evoting: hashMap creates wrong hash

[ineiti]

This is another potential security error: the hashMap method here:

cothority/evoting/lib/transaction.go

Line 109 in e0c9afb

h.Write([]byte(m[k]))

creates a hash of a map, which is difficult in go, as the map doesn't have an explicit order in go. So it takes all keys, sorts them alphabetically, and then hashes the values.

But: it doesn't add the key to the values.

So the following two maps will have the same hash:

map1 := map[string]string{
    "first": 1,
    "second": 2,
}

map2 := map[string]string{
    "a": 1,
    "b": 2,
}

Fix: also add the key to the hash.