Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DCRDEX seed format and use it as default #3940

Open
jzbz opened this issue Apr 13, 2024 · 3 comments
Open

Support DCRDEX seed format and use it as default #3940

jzbz opened this issue Apr 13, 2024 · 3 comments

Comments

@jzbz
Copy link
Member

jzbz commented Apr 13, 2024

DCRDEX has changed to a custom seed format that is considerably more user friendly than the one we are currently using (decred/dcrdex#2710). We should ideally harmonize all Decred software to be compatible and it may make sense to adopt this format as the default for Decrediton in addition to supporting restoring wallets that use this format.

Advantages:

  • Shorter.
  • BIP-39 word list is supported by all seed backup products.
  • Doesn't make use of the BIP-39 standard (only words).
  • Embedded birthday to make wallet restorations faster.

Code: https://github.com/decred/dcrdex/tree/master/client/mnemonic

@JoeGruffins
Copy link
Member

Does dcrwallet allow restoring from a date currently? If not should we add that?

@jzbz
Copy link
Member Author

jzbz commented Apr 16, 2024

Does dcrwallet allow restoring from a date currently? If not should we add that?

I don't believe it currently supports specifying a restore height, whether dcrwallet should have that feature is above my head, maybe @jrick can chime in on how best to approach this.

@jrick
Copy link
Member

jrick commented Apr 16, 2024

not currently supported but the feature would be very welcome. a birthday height can be provided either in the initial prompts or during wallet creation with an added config option. prompting for it would require saving this data to the db so it can be used later on, but we would need to do that anyways if the seed format encoded a birthday.

(a birthday date would also be alright, we can figure out a suitable height from the header timestamps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants