Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure correct behavior in library when using Playable.length() and AudioRecordingStream.getMillisecondLength() #93

Open
ddf opened this issue Feb 23, 2019 · 1 comment
Open

ensure correct behavior in library when using Playable.length() and AudioRecordingStream.getMillisecondLength() #93

ddf opened this issue Feb 23, 2019 · 1 comment
Assignees
@ddf
Labels
Bug Fix Review
Milestone
2.3.0

Comments

@ddf
Copy link
Owner

ddf commented Feb 23, 2019

These methods can return -1, which is not always treated properly by internal code like in FilePlayer cue and skip. Need to check everywhere this is used and create a test that uses a file stream with an unknown length.
@ddf ddf self-assigned this Feb 23, 2019
@ddf ddf added the Bug Fix label Feb 23, 2019
@ddf ddf added this to the 2.3.0 milestone Feb 23, 2019
ddf added a commit that referenced this issue Feb 27, 2019
@ddf
Issue #93 - handle negative millisecond length correctly in cue and s…
c061301 
…kip implementations of Playable classes

+ just for completeness, I've fixed it in AudioSnippet even though loadSnippet is deprecated and I will be changing code so that a snippet will fail to load if the file length can't be determined
ddf added a commit that referenced this issue Feb 27, 2019
@ddf
Issue #93 - fix loadFileIntoBuffer so that it will fail to load the f…
2cccff6 
…ile if the length cannot be determined
@ddf
Copy link
Owner Author

ddf commented Feb 28, 2019

Also pertains to setLoopPoints

@ddf ddf added the Review label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddf ddf

Labels
Bug Fix Review
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@ddf