Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tidy First] Refactor safe_run_hooks #10938

Open
1 task done
QMalcolm opened this issue Oct 30, 2024 · 0 comments · May be fixed by #10944
Open
1 task done

[Tidy First] Refactor safe_run_hooks #10938

QMalcolm opened this issue Oct 30, 2024 · 0 comments · May be fixed by #10944
Labels
cleanup behavior-neutral, cleanup-only

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

Safe run hooks is a little hard to follow and has some unnecessary variables. Let's try to simplify it a bit.

Acceptance criteria

safe_run_hooks is simpler`

Suggested Tests

N/A

Impact to Other Teams

N/A

Will backports be required?

No

Context

No response
@QMalcolm QMalcolm added the cleanup behavior-neutral, cleanup-only label Oct 30, 2024
@QMalcolm QMalcolm linked a pull request Oct 30, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup behavior-neutral, cleanup-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tidy-First] Refactor safe run hooks dbt-labs/dbt-core
1 participant
@QMalcolm