Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Dockerfile contribution #158

Closed
wants to merge 3 commits into from

Conversation

marvin-enthus
Copy link

Hi,

we created a Dockerfile to build a container for deployment on our build cluster. Maybe this Dockerfile could be a template for an automatic deployment to a container registry. Would this be an option for the project?

Thanks & Bye,
Chris

@Morl99
Copy link
Contributor

Morl99 commented Dec 29, 2021

Thanks for this PR, I thought about this myself, but since my hosting platform is GitHub Pages, it had no priority. I would like to publish the image to a container registry, but I need to check internally, how easy/hard it is to do within our organization.

But even without the automatic publishing, a Dockerfile within the repo has some value for users that want to run the project with Docker, so I appreciate your contribution.

Would you be able to write a few lines of documentation in the readme so other people can quickly see, that the Dockerfile is available, and how to use it?

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile.nginx.config Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Carsten Hoffmann <[email protected]>
@marvin-enthus
Copy link
Author

i'm happy with your changes. I also try to find some time add some description to the README.md

@Morl99
Copy link
Contributor

Morl99 commented May 18, 2022

I revised this and will accept the PR as is, it is better than not having anything at all, and can be a starting point for #277. Unfortunately it has a conflict, so I cannot merge it as is. Could you resolve the conflict @sa-ChristianNiessner ? We can add info in the readme in a separate PR if you do not have the resources or the motivation to do so right now ;)

@Morl99
Copy link
Contributor

Morl99 commented Aug 5, 2022

Since we now merged #342, I will close this PR. If you still want, you could rebase and tweak the Dockerfile anytime, it would be appreciated.

@Morl99 Morl99 closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants