Added "setSelection" method to code, tests, and documentation. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 18, 2016 07:51
The "setSelection" method allows an explicit list of options to be set. Deselected options in the provided list will be selected and selection options that are not in the provided list be deselected. Internally, it delegates to the "select" and "deselect" methods and gives the caller the same option for firing the onChange notification. The testing suite has been updated to validate the new feature. The tests make sure that the selection changes as it is supposed to, the onChange notification fires appropriately, and doesn't fire when requested not to do so. Finally, the documentation page has been updated to show how to use this feature with working and tested examples that are based off of the other ones already provided.
This reverts commit ebd154d.
The "setSelection" method allows an explicit list of options to be set. Deselected options in the provided list will be selected and selection options that are not in the provided list be deselected. Internally, it delegates to the "select" and "deselect" methods and gives the caller the same option for firing the onChange notification. The testing suite has been updated to validate the new feature. The tests make sure that the selection changes as it is supposed to, the onChange notification fires appropriately, and doesn't fire when requested not to do so. Finally, the documentation page has been updated to show how to use this feature with working and tested examples that are based off of the other ones already provided.
|
My first commit had a million white space changes because of my editor settings. I didn't want to submit those changes, so I rolled it back, and submitted a new one that only has the code additions that I made. That's why there are 3 commits instead of just 1. Sorry for the inconvenience. |
|
I resolved all the conflicts so the merge, should you choose to take it, should be no problem. |
|
Can't merge this automatically, will do it manually later. Thanks for the great pull request (regarding tests, documentation etc.)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "setSelection" method allows an explicit list of options to be set.
Deselected options in the provided list will be selected and selection
options that are not in the provided list be deselected. Internally, it
delegates to the "select" and "deselect" methods and gives the caller
the same option for firing the onChange notification.
The testing suite has been updated to validate the new feature. The
tests make sure that the selection changes as it is supposed to, the
onChange notification fires appropriately, and doesn't fire when
requested not to do so.
Finally, the documentation page has been updated to show how to use this
feature with working and tested examples that are based off of the other
ones already provided.