Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are bucklets gerrit specific? #3

Open
sundsdal opened this issue Aug 27, 2014 · 2 comments
Open

Are bucklets gerrit specific? #3

sundsdal opened this issue Aug 27, 2014 · 2 comments
Labels
bug

Comments

@sundsdal
Copy link

If so, why have gerrit specific code?
https://github.com/davido/bucklets/blob/master/maven_jar.bucklet#L72
@davido davido added the bug label Aug 31, 2014
@davido
Copy link
Owner

davido commented Aug 31, 2014

Well, Bucklets were extracted from Gerrit Code Review project. But this specific condition shoudn't be Gerrit specific at all. Snapshot artifacts on Maven Central have the same characteristics as on Google storage buckets.

@davido
Copy link
Owner

davido commented Aug 31, 2014

Change under review: [1].

[1] https://gerrit-review.googlesource.com/59723

davido added a commit that referenced this issue Mar 21, 2015
@davido
maven_jar(): Remove gerrit specific condition
cae5c1b 
Snapshot artifacts on Maven Central have the same characteristics as
on Google storage buckets, so that these check shouldn't be Gerrit
repository specific [1]. In fact Bucklets are not Gerrit Code Review
project specific, but a generic plugin layer for Buck build system.

[1] #3
Change-Id: I05f138cb287e3021aa4282d7bd6e9dc4e7daae56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davido @sundsdal