Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable default keybindings. #943

Closed
wants to merge 1 commit into from
Closed

Add option to disable default keybindings. #943

wants to merge 1 commit into from

Conversation

kadaliao
Copy link

@kadaliao kadaliao mentioned this pull request Aug 21, 2019
Closed
blueyed
blueyed reviewed Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok in general - although @davidhalter stated a while ago that he does not want new settings (#213 (comment)).
But it needs more adjustments - basically search for "auto_initialization" in the source, and adjust the doc/code accordingly.

btw: currently you can achieve this also be setting the various "g:jedi#X_command" settings to an empty string.

@blueyed blueyed mentioned this pull request Aug 21, 2019
Closed
@blueyed
Copy link
Collaborator

blueyed commented Aug 21, 2019

Well, quoting @davidhalter:

You can just set all the mappings to "" and nothing will happen to your settings anymore. Considering that it's just 6 settings (and you probably won't disable all of them because you want some of them!)

Maybe the doc with "auto_initialization" should just provide an example to unset all of them?
Then you can just add those 6 lines to your config, if you want to delete all of them.

@kadaliao
Copy link
Author

Well, quoting @davidhalter:

You can just set all the mappings to "" and nothing will happen to your settings anymore. Considering that it's just 6 settings (and you probably won't disable all of them because you want some of them!)

Maybe the doc with "auto_initialization" should just provide an example to unset all of them?
Then you can just add those 6 lines to your config, if you want to delete all of them.

Oh yes. I started this because I wanted to change the default mappings to avoid conflict with other plugins. Just found out that I can directly change the mappings by setting the command string.

I guess the explicit disable option will be unnecessary. 😞

blueyed added a commit to blueyed/jedi-vim that referenced this pull request Aug 22, 2019
@blueyed
doc: add example to disable all default maps
08a5f47 
Also removes section for deprecated `goto_definitions_command`.

Ref: davidhalter#213
Closes davidhalter#943
@blueyed blueyed mentioned this pull request Aug 22, 2019
Open
@blueyed
Copy link
Collaborator

blueyed commented Aug 22, 2019

@kadaliao
No worries, and thanks for the PR in the first place!

I've created #944 as a follow-up.

@blueyed blueyed closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadaliao @blueyed