refactor: [experimental] create TLS certificate via code & save it in a PersistentVolume #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the validatingwebhookconfiguration
…nto persistentVolume_poc # Conflicts: # charts/datree-admission-webhook/templates/webhook-with-cert-secrets.yaml
royhadad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for creating the TLS certificate via the webhook-server code and saving it in a PersistentVolume shared between the webhook-server's pods.
How does it work?
webhook-serverdeployment has a PersistentVolume attached to it (deployment.yaml)webhook-serverstartup, if no certificates are found in the file system, a TLS certificate and CA are created via the code and saved to the PersistentVolume via the file system.webhook-serverstarts listening for requests.webhook-serverattaches the CA to theValidatingWebhookConfigurationand enables it to start forwarding requests to thewebhook-server