Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost DATALAD_INSTALLER_VERSION on appveyor! #7380

Closed
yarikoptic opened this issue May 1, 2023 · 1 comment
Closed

boost DATALAD_INSTALLER_VERSION on appveyor! #7380

yarikoptic opened this issue May 1, 2023 · 1 comment
Assignees

Comments

@yarikoptic
Copy link
Member

we have been experiencing a broken .deb installation datalad/datalad-installer#154 and recently added even a check for content-size header but "nothing helped". Looking at the recent run https://ci.appveyor.com/project/mih/datalad/builds/46925948/job/o17iv83h4laedpk6 logs with magnifying glass I saw

python -m pip install datalad-installer${DATALAD_INSTALLER_VERSION:-}
Collecting datalad-installer==0.2.0
  Using cached datalad_installer-0.2.0-py3-none-any.whl (19 kB)
Installing collected packages: datalad-installer
Successfully installed datalad-installer-0.2.0

so we are installing a fixed very old version of it!!! Currently we have 0.11.2 ! I guess it is some env var defined at appveyor level since I dont see it in codebase. Please adjust or remove it (AFAIK installer is quite stable, and we just keep getting downloads more robust etc) @mih

yarikoptic added a commit to yarikoptic/datalad that referenced this issue May 1, 2023
Although snapshots might be more "official" and thus more "reliably present"
than our own server,  snapshots. has all kinds of throttling settings which
delay download or even cause it to fail:
datalad/datalad-installer#154

although datalad-installer should retry now (after it gets upgraded within
appveyor setup see datalad#7380) if
size changes, I think it would still be more robust to just get it from our
server.

I also made a note in
datalad/datalad-installer#160
so may be we gain possibility to specify multiple URLs thus to robustify.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -i -e s,http://snapshot.debian.org/archive/debian/20210906T204127Z/pool/main/g/git-annex/,https://datasets.datalad.org/datalad/packages/neurodebian/,g .appveyor.yml",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [
  ".appveyor.yml"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic added a commit to yarikoptic/datalad that referenced this issue May 1, 2023
Although snapshots might be more "official" and thus more "reliably present"
than our own server,  snapshots. has all kinds of throttling settings which
delay download or even cause it to fail:
datalad/datalad-installer#154

although datalad-installer should retry now (after it gets upgraded within
appveyor setup see datalad#7380) if
size changes, I think it would still be more robust to just get it from our
server.

I also made a note in
datalad/datalad-installer#160
so may be we gain possibility to specify multiple URLs thus to robustify.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -i -e s,http://snapshot.debian.org/archive/debian/20210906T204127Z/pool/main/g/git-annex/,https://datasets.datalad.org/datalad/packages/neurodebian/,g .appveyor.yml",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [
  ".appveyor.yml"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@adswa
Copy link
Member

adswa commented May 2, 2023

I found the environment variable:
image

I removed it.

@adswa adswa closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants