-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process event creation through SQS queue #195
base: master
Are you sure you want to change the base?
Conversation
AffiliationIdentifier.push_item(item) | ||
end | ||
|
||
it "returns 500 when there is error while pushing an event" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you are still working on this, but can we keep these tests which are testing the different response code for different type of requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you are still working on this, but can we keep these tests which are testing the different response code for different type of requests?
Thank you for the feedback. Checking response statuses will now be the responsibility of the worker and not the model. As such, these specs will be rewritten when I write the specs for the worker.
Purpose
Update the shoryuken config to allow enqueueing messages to the events SQS.
closes: datacite/datacite#2240
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: