Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process event creation through SQS queue #195

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Nov 27, 2024

Purpose

Update the shoryuken config to allow enqueueing messages to the events SQS.

closes: datacite/datacite#2240

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy changed the title add events to shoryuken config Process event creation through SQS queue Nov 28, 2024
AffiliationIdentifier.push_item(item)
end

it "returns 500 when there is error while pushing an event" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you are still working on this, but can we keep these tests which are testing the different response code for different type of requests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ash

I know you are still working on this, but can we keep these tests which are testing the different response code for different type of requests?

Thank you for the feedback. Checking response statuses will now be the responsibility of the worker and not the model. As such, these specs will be rewritten when I write the specs for the worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add events queue to levriero
2 participants