Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig.height and fig.width parameters are not respected for remote blocks #60

Closed
margaret-colville opened this issue Jul 22, 2024 · 2 comments
Assignees
Labels
open discussion Discussion welcomed for a decision yet to be made wontfix This will not be worked on

Comments

@margaret-colville
Copy link

If I set the fig.height and fig.width parameters for a remote code block in an rmd, the image instead is returned at the same default size as always.
fig-height-fig-width.zip

@zacdav-db zacdav-db self-assigned this Aug 20, 2024
@zacdav-db
Copy link
Contributor

I've been investigating ways to adjust this but its quite complex due to the nature of the integration.

For context, the knitr engine routes code to be executed on the specified Databricks cluster, when it does this the code is executed via slightly different mechanisms for each language. For R, it controls the size of the viz via options that would need to be adjusted and changed back for every command execution. Not only does it require it to be changed, the option doesn't apply to the command where its changed.

Long story short, supporting this currently would duplicate the number of commands sent to the cluster and add significant overhead.

My intention when building this feature was predominantly a "hack" for interactive use outside Databricks notebooks and not for it to be the vehicle to render reports as most traditionally use rmarkdown for.

I intended to either:

  1. Revisit this once the Databricks capability supports adjusting the image size options without requiring a second command
  2. Consider removing the knitr engine in order to add other features that integrate better

I'm currently leaning towards (2) as it will remove confusion and provide a more opinionated approach.

@zacdav-db zacdav-db added open discussion Discussion welcomed for a decision yet to be made will revisit Cannot make changes now and will revisit in future labels Oct 2, 2024
@zacdav-db zacdav-db added wontfix This will not be worked on and removed will revisit Cannot make changes now and will revisit in future labels Nov 3, 2024
@zacdav-db
Copy link
Contributor

Removing knitr engine from package in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open discussion Discussion welcomed for a decision yet to be made wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants