-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors! #76
Comments
I think colors are intentional and coming from https://www.dask.org/brand-guide (though maybe we haven't gotten to updating colors in all parts of the theme yet) cc @scharlottej13 as she'll know more about this |
I don't know. That background blue looks awfully like standard Sphinx. My experience doing Sphinx style guide stuff is that there are a lot of little settings you don't catch the first time around. |
(or at least, I failed at finding everything the first few times I did this) |
Yes, exactly! I met w/ Jeromy and he also sent me these additional style guides:
Yup, spot on :). I went through and tried to find how to change most things, but I'm sure there were a bunch of little things I missed. I would be happy for you or others to jump in and make modifications. I outlined a couple outstanding items in #67 too and then there's a heated discussion on footer background colors in #75. |
some options inspired by the spec sheet and discussion w/ @mrdanjlund77 option 1: black/light grey/slightly darker light grey option 2: dark blue/slightly darker light grey option 3: dark blue text, light blue background + light grey background |
Nice! My personal ranking would be (in order of decreasing preference)
@jacobtomlinson I'd be curious if you have any thoughts here |
Yup I agree with that ranking. |
Thanks all for the work on the sphinx theme. I'm curious about how we're choosing colors here. For example in our configuration reference I'm seeing the following:
Are these intentional (from a pallete somewhere?) or are we just deferring to the underlying theme? If the latter, should I just make modifications as I see fit, or do we want to consult something grander (if anyone else wants to take this away from me I'd be happy for it)
The text was updated successfully, but these errors were encountered: