Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadb docs example requires a mode #152

Open
jcushman opened this issue Apr 4, 2024 · 0 comments
Open

loadb docs example requires a mode #152

jcushman opened this issue Apr 4, 2024 · 0 comments

Comments

@jcushman
Copy link
Contributor

jcushman commented Apr 4, 2024

As of v0.5.0 this example from the docs doesn't work:

# Deserializing (loading from bytes):
db = hyperscan.loadb(serialized)

because loadb has a mandatory mode parameter. Do the docs want to be updated to db = hyperscan.loadb(serialized, mode=hyperscan.HS_MODE_BLOCK), or does loadb want a default mode value? I'm guessing you added the breaking change because it's unsafe to loadb without supplying the same mode that was used when dumping, so the fix is a docs update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant